search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

zookeeper::install is not idempotent #119

Closed stensonb closed 9 years ago

stensonb commented 9 years ago

it untars and chown's the folder on each chef-client run:

somebox01 Recipe: zookeeper::install somebox01 * zookeeper[3.4.6] action install somebox01 Recipe: somebox01 * chef_gem[zookeeper] action install (up to date) somebox01 * chef_gem[json] action install (up to date) somebox01 * group[zookeeper] action create (up to date) somebox01 * user[zookeeper] action create (up to date) somebox01 * remote_file[zookeeper-3.4.6] action create (up to date) somebox01 * directory[/opt/zookeeper] action create (up to date) somebox01 * execute[install zookeeper] action run somebox01 - execute tar -C /opt/zookeeper -zxf zookeeper-3.4.6.tar.gz somebox01 chown -R zookeeper:zookeeper /opt/zookeeper

jakedavis commented 9 years ago

Oh dang, we missed this one eh? Should be a relatively easy fix, I think.

stensonb commented 9 years ago

I agree...it doesn't bother me enough to fix it (yet!), but it should be relatively easy...I just wanted to get it documented here. :)

stensonb commented 9 years ago

To be fair, I was using version 2.4.1 of the cookbook...just upgraded to 2.5.0 via Berks...

...and, it looks like this is fixed in 2.5.0.

when is the newest release going to be pushed to the community site?