add java_opts attribute so that heap settings can be overridden by another cookbook

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.

https://supermarket.chef.io/cookbooks/zookeeper

Apache License 2.0

81 stars 117 forks source link

add java_opts attribute so that heap settings can be overridden by another cookbook #143

Closed andrewgoktepe closed 9 years ago

jeffbyrnes commented 9 years ago

@andrewgoktepe why the closure? This seems like a great feature.

jeffbyrnes commented 9 years ago

Ah, I see; you can use the node[:zookeeper][:env_vars] attribute I added in v2.0.1 instead.

jeffbyrnes commented 9 years ago

Or… I just didn’t get to #144 yet, heh.

andrewgoktepe commented 9 years ago

Yeah, I just wanted to remove the merge commit from the PR Thanks for merging #144 !

jeffbyrnes commented 9 years ago

@andrewgoktepe sure thing; love a clean history. In future, you can just git rebase -i on the branch, and force-push your newly cleaned-up branch; the pull request will update itself.