search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Add ability to configure znode ACL via node LWRP #145

Closed Annih closed 9 years ago

Annih commented 9 years ago

Zookeeper nodes have an ACL system not configured by the LWRP. This PR add ability to configure these ACLs using multiples scheme (digest, world, sasl, ip, host) It also adds authentication support to connect to zookeeper.

cc. @aboten

jeffbyrnes commented 9 years ago

@Annih oh wow, this looks great! Any chance you can add a simple test case that writes an encrypted znode using the test cookbook, and a Serverspec test that validates the znode?

Annih commented 9 years ago

Yep, I'll do that

Annih commented 9 years ago

Done! Hope it's ok for you :) Finally I also removed the host scheme because it's not supported since ZK 3.2.1.

jeffbyrnes commented 9 years ago

Looks great. I’ll pull it down & check it out next week; at MesosCon today.

jeffbyrnes commented 9 years ago

Tests well, merging in!

jeffbyrnes commented 9 years ago

Shipped in v2.12.0

Annih commented 9 years ago

Thanks a lot @jeffbyrnes, I think the LWRP needs a recursive attribute to grant ACLs to all sub nodes, but it's part of another pull request =]

Cya!

jeffbyrnes commented 9 years ago

@Annih I think that’d be a great improvement to this! PR is welcome if you manage to get ’round to it.