Remove EOL ubuntu 1404 + default to JDK 8 + fix converge & tests

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.

https://supermarket.chef.io/cookbooks/zookeeper

Apache License 2.0

81 stars 117 forks source link

Remove EOL ubuntu 1404 + default to JDK 8 + fix converge & tests #220

Closed hrak closed 5 years ago

hrak commented 5 years ago

This PR does the following:

Remove support for EOL Ubuntu 14.04
Default to JDK version 8, because version 7 is EOL and support has been removed from recent versions of the java cookbook
Test with Chef client 14
Disable deprecations_as_errors to allow cookbook to converge on Chef 14 CHEF-25 is triggered due to inclusion of 'build-essential' cookbook, required for Chef clients < 14
Test on Ubuntu 16.04

hrak commented 5 years ago

Builds are failing because zookeeper-3.4.12.tar.gz is no longer available on the source.

jeffbyrnes commented 5 years ago

@hrak I’ve merged in #219, if you would please rebase against master & force-push this branch again, we should see if the build succeeds.

I’m not using this cookbook actively right now, but I’ll see if I can find a few cycles to give this some review when I can.

jeffbyrnes commented 5 years ago

@hrak FYI, the email address associated with these commits isn’t associated with your GitHub account; you may wish to do that so that your name these commits links to your profile, and also, so that these commits are reflected in your profile.

hrak commented 5 years ago

@hrak FYI, the email address associated with these commits isn’t associated with your GitHub account; you may wish to do that so that your name these commits links to your profile, and also, so that these commits are reflected in your profile.

Thanks for mentioning, i have added the address to my profile

jeffbyrnes commented 5 years ago

@hrak I released v12.0.0 to include your changes here, plus #219, and other changes I made myself.

Thanks!