search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Duplicate acl_<scheme> before update #222

Closed kamaradclimber closed 4 years ago

kamaradclimber commented 4 years ago

This is necessary in chef 14 since default values are frozen

Change-Id: I352a3449abb0135b65529dc68f5211213b60b7e6

jeffbyrnes commented 4 years ago

Thanks @kamaradclimber! Does this have any negative impact on Chef 13?

I realize that’ll be EOL in a month, but it’s nice to preserve functionality if we can, and call it out if we cannot.

kamaradclimber commented 4 years ago

I have not tested with chef 13 but i dont see any potential breakage since it is simply a duplication of an object.

On Mon, Mar 9, 2020, 19:46 Jeff Byrnes notifications@github.com wrote:

Thanks @kamaradclimber https://github.com/kamaradclimber! Does this have any negative impact on Chef 13?

I realize that’ll be EOL in a month, but it’s nice to preserve functionality if we can, and call it out if we cannot.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/evertrue/zookeeper-cookbook/pull/222?email_source=notifications&email_token=AAD254NG7KGNKUEXYLCE4XLRGVBTDA5CNFSM4LEN72B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOISXYI#issuecomment-596716513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD254OI7RY4AMO3IXOLEALRGVBTDANCNFSM4LEN72BQ .

kamaradclimber commented 4 years ago

I don't think there is incompatibility with old chef versions