search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Inconsistency in username properties across resources #226

Closed hrak closed 4 years ago

hrak commented 4 years ago

There is an inconsistency in the username properties for the resources. For the zookeeper and zookeeper_service resources the property is username, while for the zookeeper_config resources it is user.

jeffbyrnes commented 4 years ago

Good point.

I’ve been thinking of collapsing these into a single resource; any thoughts on that?

jeffbyrnes commented 4 years ago

Regardless of whether they are collapsed together, or not, this will be a breaking change. I’m working on dropping Chef 14 support anyway in #225, so I’ll handle this then, too.