maintain backwards compatibility with ruby version 1.8.7

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.

https://supermarket.chef.io/cookbooks/zookeeper

Apache License 2.0

81 stars 117 forks source link

maintain backwards compatibility with ruby version 1.8.7 #36

Closed dbachelder closed 11 years ago

dbachelder commented 11 years ago

use File.exists? instead of Dir.exists? for 1.8.7 compatibility (1.8.7 is used on the default opsworks version of Ubuntu) move idempotency into resource def add to change log

whilp commented 11 years ago

internally, we prefer to skip creating resources (instead of guarding action with not_if); for this PR, the change to not_if seems orthogonal.
+1 for File.exists; can you make the namespace explicit (ie ::File.exists)?
holy heck -- opsworks requires 1.8.7????!!!?

dbachelder commented 11 years ago

Ok, I reversed the not_if change.. I didn't realize that was the convention. Also used ::

re 1.8.7: yeah... i know!

mwhooker commented 11 years ago

thank you for the PR!

jakedavis commented 11 years ago

@mwhooker don't forget version.