search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

use switch to handle different configtypes. #49

Closed mwhooker closed 10 years ago

mwhooker commented 10 years ago

Not sure how I feel about this stype in attributes

cc @asher

asher commented 10 years ago

Thanks for cleaning that up! Switches in attributes/default.rb appear to be fairly common and the code is clear and readable, so I think it's a good call.

jakedavis commented 10 years ago

The only problem here is it forces you to override this value in an attributes file.

mwhooker commented 10 years ago

@jakedavis good point. I'll fix it up so that opt filling happens in the recipe

jeffbyrnes commented 10 years ago

:+1: to this and #48. Thanks for fixing this up!

mwhooker commented 10 years ago

this doesn't apply cleanly any more and I question the value.