better model for mutually exclusive attributes

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.

https://supermarket.chef.io/cookbooks/zookeeper

Apache License 2.0

81 stars 117 forks source link

better model for mutually exclusive attributes #57

Closed mwhooker closed 10 years ago

mwhooker commented 10 years ago

I don't like how implicit everything is. attempted to clean up in #49, but it was sort of ill-conceived

[ ] configtype
[ ] install_method

mwhooker commented 10 years ago

Having switch logic in attributes probably would work fine.

The fact that we merged a commit which made IAM usage implicit based on the existence of an s3config file broke it.

jakedavis commented 10 years ago

We definitely need better logic around this. All of the current config was moved out as-is to the Exhibitor cookbook. Going to track in a similar issue there. This will be relevant to this cookbook as well though.

jakedavis commented 10 years ago

I think we're doing pretty good here.

jakedavis commented 10 years ago

Oh man, @mwhooker, WTF I thought you would still have collab on this. I am fixing that now.

jakedavis commented 10 years ago

Sorry man, should be fixed now. I added you to exhibitor too, same with @jeffbyrnes and @eherot.