search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

Removed upstart. Added runit instead #63

Closed gansbrest closed 10 years ago

gansbrest commented 10 years ago

Faced the same issues with upstart mentioned here https://github.com/SimpleFinance/chef-zookeeper/issues/54

Not a big fan of upstart lately, so I replaced it with runit support. Works like a charm for me on RHEL.

Hope to see it merged.

mwhooker commented 10 years ago

awesome, will take a closer look soon and probably merge this in. as you saw, there've been a few attempts recently to add runit support/get off upstart, but there've been various issues with the patches.

thanks!

gansbrest commented 10 years ago

Any updates here? We've been using it on prod for a while.

drazzib commented 10 years ago

Hi,

I'm interrested in getting runit support merged into this cookbook. Is there any blocking issue with proposed PR ?

Cheers,

jakedavis commented 10 years ago

Hey all, I might have a moment to take a look at this this afternoon. We definitely want Runit here. Thanks for your patience.

jakedavis commented 10 years ago

Merged into a new branch with a couple more edits and rebase in https://github.com/SimpleFinance/chef-zookeeper/pull/72

This will be merged in the next 15 minutes barring any additional comments. Thank you @gansbrest!

(And additional thanks @drazzib for poking at us to get it merged).