search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Merge gansbrest exhibitor runit support #72

Closed jakedavis closed 10 years ago

jakedavis commented 10 years ago

Supercedes https://github.com/SimpleFinance/chef-zookeeper/pull/63

mwhooker commented 10 years ago

just a heads up that this dramatically changes existing behavior with the removal of check-local-zk.py

whereas before it wouldn't start until the local ZK was listening, now it starts immediately (afaict). This will affect recipes which access local zk for discovery, etc, eg storm in vagrant.

jakedavis commented 10 years ago

Hmm, yeah I see what you mean. What happens pre-200? I feel like Runit will be able to handle that case for the most part, but I'm not too familiar with how ZK behaves. I mean, it kind of makes sense since it's gotta spin up the JVM and stuff.

jakedavis commented 10 years ago

Gonna re-add the script, bump 2.0.0, and add a note about this.

jakedavis commented 10 years ago

Okay, did all that. Should be in a sane spot now. I'll leave this open for comment briefly and then merge tonight barring objections (which there very well may be).