search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

zookeeper chef gem requires 'patch' utility on CentOS, probably RHEL #73

Closed mstyne closed 10 years ago

mstyne commented 10 years ago

Thanks for your work on this handy cookbook.

Unfortunately, deployment of the cookbook fails on CentOS hosts that do not have 'patch' installed.

ERROR: Failed to build gem native extension.

        /opt/chef/embedded/bin/ruby extconf.rb
Building zkc.
tar xzf zkc-3.4.5.tar.gz 2>&1
patch -p0 < patches/zkc-3.4.5-logging.patch 2>&1
sh: patch: command not found

The 'patch' package should be added as a dependency; fortunately the package is named the same across CentOS, Debian, and Ubuntu.

Thanks!

jakedavis commented 10 years ago

Hey @mstyne, thanks for the report. I actually am having trouble reproducing this; could you describe your setup? Which version of Centos/Chef, and what's your run list like?

jakedavis commented 10 years ago

(Which important to note isn't to say I don't believe you! I just want to verify the change and add some test-kitchen support generally)

mstyne commented 10 years ago

Hi @jakedavis, and thanks for the quick reply.

$ cat /etc/issue
CentOS release 6.5 (Final)
Kernel \r on an \m

$ chef-client --version
Chef: 11.10.4

A gist with full chef-client output is available here:

https://gist.github.com/mstyne/5903a6e312a0c7eafa89

And on my workstation:

$ knife cookbook show zookeeper
zookeeper   1.7.0

The CentOS Vagrant base box was generated using the 'minimal' ISO, which likely doesn't include 'patch' by default.

Thanks, Mike

jakedavis commented 10 years ago

Alright cool, should hopefully be fixed by #74. Thanks again.