evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Feature/split exhibitor #76

Closed wolf31o2 closed 10 years ago

wolf31o2 commented 10 years ago

This is the super simple new zookeeper cookbook with exhibitor removed. This, along with wolf31o2/chef-exhibitor#1 will resolve SimpleFinance/chef-zookeeper#75 and allow for me to fix mdsol/mesos_cookbook#33 by changing its dependencies to: recommends exhibitor

This should make it easier for me to allow mesos to use my hadoop::zookeeper and hadoop::zookeeper_server recipes

jakedavis commented 10 years ago

This is a pretty dramatic change. I'm still chewing through all the different pieces; this looks to basically eliminate the cookbook, which kind of makes me feel like there could be a better solution. I'm gonna continue to think on this a bit. Apologies for the delay.

BarthV commented 10 years ago

:+1: I Absolutely need clean ZK cookbook, with startup scripts, etc. After many tests, driving ZK Ensemble with Chef is really painful (without S3 or NFS) since exhibitor is really not Chef compliant (we should be able to make "auto server list management" read-only if needed : right now, auto edit feature is not relevant and non effective if we feed exhibitor.properties automaticly).

Can I help this project to go faster ? Got some cooking mojo & time ...

jakedavis commented 10 years ago

Hi,

I think the point I'm gonna have to start at is merging wolf31o2/chef-exhibitor#1 and coming back to this PR after. At that point, at least the exhibitor cookbook exists as a kind of intermediary step.

I'll try to do this tonight. Sorry for the delay. Like I said it's kind of a large change.

BarthV commented 10 years ago

ty very much for your work :) I'll pin this project and follow the future merges

jakedavis commented 10 years ago

I merged the other PR, I don't have admin on it so I can't move it back here, but this is beginning to roll.

wolf31o2 commented 10 years ago

@jakedavis You should be able to transfer it. Are you an admin on your side? screen shot 2014-05-28 at 6 09 52 pm

jakedavis commented 10 years ago

Yup. When I click on your exhibitor cookbook I don't have an admin/settings tab. I'm not sure what the usual procedure is for this. Obviously Opscode just did this with a lot of their cookbooks so what the heck.

jakedavis commented 10 years ago

Cool, I think we figured it out. Thanks @wolf31o2. I've transferred it here.

jakedavis commented 10 years ago

We're focusing on Zookeeper again internally and that gives me a chance to really dig into this cookbook. I plan to merge this PR via #83 as well as do quite a big rewrite of several pieces of it.

wolf31o2 commented 10 years ago

Be sure to check out hadoop::zookeeper and hadoop::zookeeper_server and see if there's anywhere that we can work together on this. I already do configuration, initialization, etc. Maybe we can move code from my cookbooks to yours and have mine depend on yours. Win-win.

jakedavis commented 10 years ago

Sure thing. Once the LWRP is done, I think translating the config stuff to a provider will be next. Gonna close this PR and track first bits in #83.