search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Move build-essential compile_time option to attribute file #82

Closed davidgiesberg closed 10 years ago

davidgiesberg commented 10 years ago

Resolves issue #81

davidgiesberg commented 10 years ago

Good point - correction made

jakedavis commented 10 years ago

Alright cool, looks good, +1, will merge later tonight (because I am lazy) or if someone else gets to it first they can too :)

jeffbyrnes commented 10 years ago

@jakedavis all set. Maybe a good time to ask @mwhooker what the process is for using the Makefile to cut a release properly? As has been suggested elsewhere, you might also take advantage of Stove to replace a lot of what that Makefile does.

davidgiesberg commented 10 years ago

Cool, thanks guys.

BTW, I'm not a customer, but I'm a fan of the cool stuff Simple is doing!

jakedavis commented 10 years ago

@davidgiesberg, very much appreciated :) if you ever want to be a customer, you should go for it!

@jeffbyrnes, yeah, to be honest I don't use the Makefile. At this point I'd have just done a separate commit to bump and update the changelog straight to master. Wouldn't have forgotten to tag this time too :)

jeffbyrnes commented 10 years ago

@jakedavis :+1: to that method, works just fine. I think the Makefile automates the creation of the artifact to ship to the Community site, in addition to tagging the release. I'm not the best with make, however, so I could be a bit off on that.