evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

Use our Java #84

Closed jakedavis closed 9 years ago

jakedavis commented 10 years ago

@miah wrote a kickass cookbook for Java that we should definitely use.

jeffbyrnes commented 10 years ago

@jakedavis we use the community Java cookbook (aka https://github.com/socrata-cookbooks/java) at EverTrue; I'm curious what improvements SimpleFinance/java offers (we're always on the hunt for stronger cookbooks).

miah commented 10 years ago

The java cookbook in question basically implements RVM for java.

jeffbyrnes commented 10 years ago

@miah damn. Ok, that is some hot shit. Nicely done!

miah commented 10 years ago

I wrote it in haste. It definitely needs attention and cleanup. But we're working on cleaning up our code lately (as you can see), so we'll get to it soon I'm sure.

solarce commented 10 years ago

This was merged in in the following commits

jeffbyrnes commented 9 years ago

I'm going to close this, as 76910ae (released in v2.4.2) makes it possible to specify, in a wrapper cookbook, that node[:zookeeper][:use_java_cookbook] = false and use your own Java cookbook instead.

I think this is a great pattern to follow for this cookbook, as it’s become a really strong community cookbook for installing Zookeeper, and sticking to using other community cookbooks by default is a Good Thing™.

jakedavis commented 9 years ago

Excellent :)