search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 117 forks source link

Write some tests #85

Closed jakedavis closed 8 years ago

jakedavis commented 10 years ago

Now that this is approaching LWRP form (#83), we should write some tests and hook it into TravisCI/Coveralls.

jeffbyrnes commented 10 years ago

@jakedavis hooking up to do Foodcritic, RuboCop, and ChefSpec testing using Travis is pretty straightforward, but getting a Test Kitchen convergence is a bit trickier. It can be done, however, though it requires using EC2, Digital Ocean, Rackspace, or some other mechanism to actually create the virtual machine for testing, since you can't create a VM on Travis.

Just an FYI on this, since I'm in the middle of wrangling with Travis automation myself for cookbooks.

jakedavis commented 10 years ago

Good to know. Yeah, I definitely like the more test-based approach. Mostly TK is nice because we kind of promised some CentOS support on this cookbook previously (we're completely Ubuntu). Tests will help mitigate the concerns though :)

jeffbyrnes commented 10 years ago

We're completely Ubuntu as well, so yeah, if you're looking to promise CentOS, TK is the way to go.