search

evertrue / zookeeper-cookbook

Chef cookbook for installing and managing Zookeeper.
https://supermarket.chef.io/cookbooks/zookeeper
Apache License 2.0
81 stars 119 forks source link

Implement zookeeper_service #86

Closed jakedavis closed 8 years ago

jakedavis commented 10 years ago

The Zookeeper docs recommend process supervision. As a baseline, we should have a resource which basically calls zkServer.sh start. But as a more resilient solution, we should probably have a Runit option, and possibly others depending on peoples' cup of tea.

jeffbyrnes commented 10 years ago

What's the status of this, @jakedavis? Had some great momentum going!

jakedavis commented 10 years ago

Ha, status is we have a service internally and maybe I should slurp it into this cookbook :) I think I did take a swing at a zookeeper_service resource, but it got messy quickly when I tried to be dynamic about it.

Thinking at the least we can add a node[:zookeeper][:service_style] attribute that defaults to runit, run a case on it in a service recipe and then just have Runit for now. The Sensu cookbook kind of does this (here), so maybe using that as inspiration might work.

jeffbyrnes commented 10 years ago

@jakedavis sounds like a great path to tread to get this to a minimally working state. Thanks also for access to SimpleFinance/chef-exhibitor.

jakedavis commented 10 years ago

Alright, took a swing at it in https://github.com/SimpleFinance/chef-zookeeper/pull/91

solarce commented 10 years ago

Since we usually use upstart to manage services, here's a stab at some upstart supprt

corbesero commented 8 years ago

Is there some way to control what user zookeeper is run as using runit? If I use systemv, zookeeper runs as zookeeper. But with runit, it always seems to start up as root.

jeffbyrnes commented 8 years ago

@corbesero that’d be a separate issue, which I’ve opened here: #166. This issue is meant to cover a refactor of how the service is set up; it should be refactored as its own custom resource.

jeffbyrnes commented 8 years ago

I think this would best be served as part of a larger refactor of the LWRPs into Chef 12.5-style custom resources.