search

everweij / react-laag

Hooks to build things like tooltips, dropdown menu's and popovers in React
https://www.react-laag.com
MIT License
907 stars 47 forks source link

[BUG] React-18 Support #89

Closed msdrigg closed 1 year ago

msdrigg commented 2 years ago

Describe the bug Update peerDependencies to support react 18.

To Reproduce Steps to reproduce the behavior:

  1. Add react-laag into a project with react 18
  2. Try to compile
  3. Note that there is warnings and/or errors

Expected behavior React-Laag should support react 18

Additional context I have been using react-laag with react-18 for a bit now, and it works. I don't know if there are any subtle issues I haven't noticed, but it seems to work great.

rokasce commented 2 years ago

Any updates on the issue?

reintroducing commented 2 years ago

there is a PR https://github.com/everweij/react-laag/pull/90 open with an apparent fix. It would be great to get it merged and close this out.

everweij commented 1 year ago

PR #90 just got merged, so I'm closing this issue. Feel free to open this issue again if you are experiencing any React 18 related issues.