everydayrails / everydayrails-rspec-2017

Sample source for the 2017 edition of Everyday Rails Testing with RSpec.
http://rspectutorial.com
312 stars 247 forks source link

Chapter 4, inconsistent project name and description #93

Open JunichiIto opened 5 years ago

JunichiIto commented 5 years ago

This issue was reported by a Japanese edition reader.

In chapter 4, Associations in factories and Avoiding duplication in factories, there are some of project name and description, but they are inconsistent. Some are "Project #{n}" and "A test project." and the others are "Test Project #{n}" and "Sample project for testing purposes".

screen shot 2018-10-06 at 8 48 24 screen shot 2018-10-06 at 8 50 57

In GitHub, :project factory has "Project #{n}" and "A test project." However, Non-DRY versions are "Test Project #{n}" and "Sample project for testing purposes".

https://github.com/everydayrails/everydayrails-rspec-2017/blob/04-factories/spec/factories/projects.rb

The reader is saying this issue might make beginners confused, so please review and consider to fix them.