search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Don't show seat count if there's no position or seat count defined #102

Closed crowbot closed 5 years ago

crowbot commented 5 years ago

This is fixing the problem seen at https://github.com/everypolitician/proto-commons-taiwan/pull/31/commits/ba72cd38098344ea04cb06c88c2ab8d8b84d9264#diff-c423aa3204bf24fec2c4cf4394556ae7R20

codecov[bot] commented 5 years ago

Codecov Report

Merging #102 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   94.58%   94.65%   +0.06%     
==========================================
  Files          36       36              
  Lines         850      860      +10     
==========================================
+ Hits          804      814      +10     
  Misses         46       46
Impacted Files Coverage Δ
lib/commons/builder/legislature.rb 95.55% <100%> (+0.2%) :arrow_up:
test/commons/builder/legislature_test.rb 95% <100%> (+3.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f51e881...0528a68. Read the comment docs.

crowbot commented 5 years ago

BUILD PROCESS: Don't add empty seat counts

crowbot commented 5 years ago

BUILD PROCESS: Don't include seat counts if there's no data for them