Closed alexdutton closed 6 years ago
Merging #103 into master will increase coverage by
0.07%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 94.65% 94.72% +0.07%
==========================================
Files 36 36
Lines 860 872 +12
==========================================
+ Hits 814 826 +12
Misses 46 46
Impacted Files | Coverage Δ | |
---|---|---|
lib/commons/builder/legislature.rb | 95.91% <100%> (+0.36%) |
:arrow_up: |
test/commons/builder/legislative_index_test.rb | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1b65e46...97df044. Read the comment docs.
Added an explanatory comment to the query :-)
Two related changes:
This means we'll no longer have
"position_item_id": null
in our legislative index, which causes trouble down the line, and we'll be warned of legislatures without positions. We also now exclude legislatures that have legislatures within them — see second commit message for more detail.