search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Only integrity-check WIKIDATA in boundaries/build CSV files #105

Closed alexdutton closed 5 years ago

alexdutton commented 5 years ago

Previously, this checked every CSV under boundaries, which included those in boundaries/source/, not all of which are guaranteed to be UTF-8. Any non-UTF-8 source CSV therefore caused the integrity checks to fail with an exception when parsed.

This does mean that repositories with boundaries not in boundaries/build/ don't have their CSV files checked, but those are becoming increasingly rare, and can/should be moved to use boundaries/build.

codecov[bot] commented 5 years ago

Codecov Report

Merging #105 into master will decrease coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   94.72%   94.65%   -0.08%     
==========================================
  Files          36       36              
  Lines         872      860      -12     
==========================================
- Hits          826      814      -12     
  Misses         46       46
Impacted Files Coverage Δ
lib/commons/builder/legislature.rb 95.55% <0%> (-0.37%) :arrow_down:
test/commons/builder/legislative_index_test.rb 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9cdc8e...b76d844. Read the comment docs.