everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Ignore dissolved positions in executive index and position-data #111

Closed alexdutton closed 5 years ago

alexdutton commented 5 years ago

This extends previous work with legislative positions to also ignore dissolved positions in executive index and position data queries

Also includes some clause reordering for clarity.

No tests as it's just a query change and we struggle to test those.

Follows on from #110, which only covered the legislative index.

codecov[bot] commented 5 years ago

Codecov Report

Merging #111 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          36       36           
  Lines         890      890           
=======================================
  Hits          844      844           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30ee2a4...f41718d. Read the comment docs.