everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Only filter out replaced terms if they don't have end dates. #116

Closed alexdutton closed 5 years ago

alexdutton commented 5 years ago

This means we no longer exclude current terms if someone has created the next (future) term in Wikidata and added a "followed by" statement to the current term.

See comments in the code for an explanation of the logic of the new behaviour.

An example of this in use with a cut-down query for Brazil's Senate shows both the current and future terms: http://tinyurl.com/y85aky87

codecov[bot] commented 5 years ago

Codecov Report

Merging #116 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          36       36           
  Lines         905      905           
=======================================
  Hits          859      859           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1377a78...1307323. Read the comment docs.