search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Exclude memberships that overlap a term, but which are for another term #118

Closed alexdutton closed 5 years ago

alexdutton commented 5 years ago

If a membership overlaps the term we're querying about through an explicit start or end date, but it's also linked to another term then we want to exclude it because it's likely not been updated with an end date yet.

This is particularly important when querying about future terms, as current memberships can't yet be given an end date, but it can't be assumed that the membership also applies to the future term.

No tests as this is just a query change.

codecov[bot] commented 5 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          36       36           
  Lines         918      918           
=======================================
  Hits          872      872           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c973004...6e8731d. Read the comment docs.