search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Fix the null parent_id check #120

Closed alexdutton closed 5 years ago

alexdutton commented 5 years ago

!str == otherStr will always be false, regardless of whether or not str and otherStr are equal, as ! binds more tightly than ==, turning the LHS into false.

This bug explains why this warning was never effective.

No tests as we (wrongly) don't test bin/build.

Resolves #119.

codecov[bot] commented 5 years ago

Codecov Report

Merging #120 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          36       36           
  Lines         918      918           
=======================================
  Hits          872      872           
  Misses         46       46

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7b8d37...08daf1f. Read the comment docs.