search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Use wdt: instead of p:/ps: for finding role_superclass relationships #22

Closed mhl closed 6 years ago

mhl commented 6 years ago

The p:P279/ps:P279 relation wasn't right - if anything it should have been (p:P279/ps:P279) but that always seems to time out. wdt:P279* works, and we don't know of any cases where using wdt: causes problems so far, so switch both the constraints on role_superclass to use wdt instead.

In addition, we use a '+' instead of '*' when checking that ?role_superclass is a subclass (at some level) of 'legislator', so that we don't end up with ?role_superclass just being 'legislator' (which isn't useful to know, since we know these are legislative positions already).

codecov[bot] commented 6 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   67.55%   67.55%           
=======================================
  Files          17       17           
  Lines         299      299           
=======================================
  Hits          202      202           
  Misses         97       97
Impacted Files Coverage Δ
lib/commons/builder/wikidata_queries.rb 33.33% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e59dc73...5704c79. Read the comment docs.