search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Allow additional admin areas to be specified in config.yaml #50

Closed alexdutton closed 6 years ago

alexdutton commented 6 years ago

This adds:

codecov[bot] commented 6 years ago

Codecov Report

Merging #50 into master will decrease coverage by 54.66%. The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #50       +/-   ##
===========================================
- Coverage   92.25%   37.59%   -54.67%     
===========================================
  Files          27       22        -5     
  Lines         633      516      -117     
===========================================
- Hits          584      194      -390     
- Misses         49      322      +273
Impacted Files Coverage Δ
test/commons/builder/config_test.rb 41.66% <33.33%> (-58.34%) :arrow_down:
lib/commons/builder/config.rb 50% <50%> (-50%) :arrow_down:
test/commons/builder/executive_test.rb 29.16% <0%> (-70.84%) :arrow_down:
lib/commons/builder/legislature.rb 24.24% <0%> (-69.7%) :arrow_down:
test/commons/builder/boundary_data_test.rb 31.25% <0%> (-68.75%) :arrow_down:
test/commons/builder/membership_data_test.rb 31.42% <0%> (-68.58%) :arrow_down:
test/commons/builder/legislative_term_test.rb 37.5% <0%> (-62.5%) :arrow_down:
lib/commons/builder/wikidata_queries.rb 37.5% <0%> (-62.5%) :arrow_down:
lib/commons/builder/executive.rb 31.03% <0%> (-62.07%) :arrow_down:
lib/commons/builder/membership_data.rb 28.94% <0%> (-60.53%) :arrow_down:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d3db4a...cc9fcc3. Read the comment docs.

alexdutton commented 6 years ago

I agree on the point about Q24238356 (unknown). I'm thinking of just changing those admin area types to strings of "national", "regional", "local".

alexdutton commented 6 years ago

Note to self: The online merge tool was too risky, and an oversight on my part broke CI on master. Let's not do that again :-(. Now fixed up manually from a terminal and pushed.