search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Always use legislature position for exposed/serialized role. #77

Closed alexdutton closed 6 years ago

alexdutton commented 6 years ago

If there's a term-specific position, we should use it to find results, but should still expose the generic position ID in results, to hide the vagaries of there being a term-specific position.

This also means that the associated positions in the boundaries index can use the generic position ID, and won't need updating every time a new term starts (with its associated position).

Closes #76.

codecov[bot] commented 6 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #77      +/-   ##
=========================================
+ Coverage   94.17%   94.2%   +0.03%     
=========================================
  Files          33      33              
  Lines         772     776       +4     
=========================================
+ Hits          727     731       +4     
  Misses         45      45
Impacted Files Coverage Δ
test/commons/builder/legislative_term_test.rb 100% <100%> (ø) :arrow_up:
lib/commons/builder/legislative_term.rb 90.32% <100%> (+0.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ec3fc7...ec74773. Read the comment docs.