everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Configure threshold for inclusion of cities/regions on a per-country basis. #80

Open jacksonj04 opened 6 years ago

jacksonj04 commented 6 years ago

In a country's config.json it should be possible to specify the population threshold at which a city or region is considered for inclusion.

https://github.com/everypolitician/commons-builder/blob/e21c67cf20b9d47ceb7d4e9f23f917a1fff76750/lib/commons/builder/queries/select_admin_areas_for_country.rq.liquid#L17

crowbot commented 6 years ago

What would this enable that can't happen at the moment?

jacksonj04 commented 6 years ago

The threshold for inclusion has changed once previously, and it makes sense for the change in what is fundamentally being asked of a country's queries to happen when the country's proto-commons configuration is changed, not when an arbitrary value in an upstream dependency is changed.