search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Executive.list> handle one executive having multiple positions #86

Closed alexdutton closed 6 years ago

alexdutton commented 6 years ago

Previously this would attempt to create a new Executive object per position and then fail to sort them. This now groups all positions for a given executive into the same Executive object.

Closes #85.

codecov[bot] commented 6 years ago

Codecov Report

Merging #86 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   94.53%   94.59%   +0.05%     
==========================================
  Files          35       35              
  Lines         824      833       +9     
==========================================
+ Hits          779      788       +9     
  Misses         45       45
Impacted Files Coverage Δ
test/commons/builder/executive_test.rb 100% <100%> (ø) :arrow_up:
lib/commons/builder/executive.rb 93.93% <100%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 605d5d1...6188766. Read the comment docs.