search

everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Handle legislative positions that subclass other positions we return #88

Closed alexdutton closed 6 years ago

alexdutton commented 6 years ago

If a house has multiple position 'has part's, and one subclasses another, then we don't need to include the subclass position in the legislative index. We can find holders of the subclass position in the legislative membership query.

This doesn't handle the case of a house having 'has part' positions that don't subclass each other, which will still cause duplicated entries in the legislative index, for which we should warn.

No tests as this is just ("just") query changes, which we never satisfactorily test anyway.

Closes #87.

alexdutton commented 6 years ago

Also tested for the UK, to ensure that it doesn't make things awkward with respect to term-based position items.

codecov[bot] commented 6 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          35       35           
  Lines         833      833           
=======================================
  Hits          788      788           
  Misses         45       45

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a2d5fd...6e423c6. Read the comment docs.