everypolitician / commons-builder

Build scripts for Democratic Commons repositories
MIT License
1 stars 0 forks source link

Date-aware term condition #95

Closed alexdutton closed 6 years ago

alexdutton commented 6 years ago

This extends the term condition subquery to include memberships (P39s) that aren't directly attached to the term with a "parliamentary term" qualifier, but whose start/inception dates overlap the term to some extent.

This helps support legislatures where members are appointed for life but where there is a background parliamentary term system, e.g. in the Canadian Senate and the British House of Lords. Examples:

See the comment in the term_condition query template for a further explanation of logic encoded in the query.

No tests, as it's a query change against upstream data and we're not good at testing that.

codecov[bot] commented 6 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #95   +/-   ##
======================================
  Coverage    94.6%   94.6%           
======================================
  Files          35      35           
  Lines         834     834           
======================================
  Hits          789     789           
  Misses         45      45

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2465e18...55b90a5. Read the comment docs.