Update mediawiki output

everypolitician / compare_with_wikidata

Library for diffing Wikidata and CSVs

MIT License

2 stars 0 forks source link

Update mediawiki output #10

Closed chrismytton closed 7 years ago

chrismytton commented 7 years ago

Tidy up the MediaWiki output when running with PROMPT_OUTPUT_FORMATTER=mediawiki.

Fix bug with SPARQL query rendering
Show scraper and SQL used for report
Output "none" if there are no matches for a subsection

Before merging

[x] Once #9 is merged change the target branch of this pull request to master

chrismytton commented 7 years ago

Looks good on the whole, 👍 but could you improve the commit message for "Update output to group into two sections" possibly to explain why we're switching to just two sections? I'm not saying that this is the only place that reasoning should be written down, of course, but certainly when looking back through the git history it would be nice to know :)

Oops, good shout! Have amended that commit message and force pushed the branch.

chrismytton commented 7 years ago

Closing this in favour of #20 because the MediaWiki output has changed significantly in that pull request, making this pull request redundant.