Re-enable `ensure-regression-tests`

everypolitician / compare_with_wikidata

Library for diffing Wikidata and CSVs

MIT License

2 stars 0 forks source link

Re-enable `ensure-regression-tests` #118

Closed tmtmtmtm closed 6 years ago

tmtmtmtm commented 6 years ago

These were turned on in ec197f48, but then turned back off again (without explanation) in a3e42656. As it's not clear why we wouldn't want them, and we've had code sneak through untested, turn them back on again.

Note to reviewer

It would be preferable not to merge this before the other PRs opened in the last couple of days, as we'd need to rename the branches in some of those.

chrismytton commented 6 years ago

I'm going to merge this as it will be useful to have it enabled for the changes I'm going to do for #119. However this does mean that https://github.com/everypolitician/compare_with_wikidata/pull/115 will need to be closed and re-created on a branch that contains refactor in the name. Since there hasn't been any discussion on that pull request that we'd lose I think that's OK.

tmtmtmtm commented 6 years ago

:+1: I've opened #120 as a replacement for #115