Handle comparing on multiple values

everypolitician / compare_with_wikidata

Library for diffing Wikidata and CSVs

MIT License

2 stars 0 forks source link

Handle comparing on multiple values #12

Closed chrismytton closed 7 years ago

chrismytton commented 7 years ago

At the moment we're just comparing two lists based on the Wikidata identifier. It would be good if we could compare on multiple values, e.g. Wikidata ID + name, or for Heads of Government we'd want to compare on the triple (country, office, office holder).

lucychambers commented 7 years ago

Suggestion: Only solve for the specific cases as you come across them.

chrismytton commented 7 years ago

This was fixed by switching to daff for comparisons. See #19 and #20.