search

everypolitician / compare_with_wikidata

Library for diffing Wikidata and CSVs
MIT License
2 stars 0 forks source link

Refactor DiffOutputGenerator#comparison method #123

Open chrismytton opened 6 years ago

chrismytton commented 6 years ago

This fixes an error which was being reported by reek. The refactoring also makes the #comparison method a bit more idiomatic.

The full error from reek was:

[17]:InstanceVariableAssumption: CompareWithWikidata::DiffOutputGenerator assumes too much for instance variable '@comparison' [https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md]

https://github.com/troessner/reek/blob/master/docs/Instance-Variable-Assumption.md

Notes to reviewer

This might be easier to review without whitespace changes.