search

everypolitician / compare_with_wikidata

Library for diffing Wikidata and CSVs
MIT License
2 stars 0 forks source link

Switch to using everypolitician-ruby/popolo #2

Closed chrismytton closed 7 years ago

chrismytton commented 7 years ago

Rather than manually getting the popolo and digging through it for the identifiers we should instead be using everypolitician-ruby.

chrismytton commented 7 years ago

If there are things that the libraries don't do already that would be useful, e.g. person.wikidata_id, then we should add that as it will be useful to others as well.

tmtmtmtm commented 7 years ago

person.wikidata_id

NB: .wikidata is already implemented on Entity, so should be accessible anywhere that's already reconciled (e.g. people, parties, legislature, terms, areas)

chrismytton commented 7 years ago

Done in https://github.com/everypolitician/compare_morph_to_wikidata/commit/b944122afd67a78e7a4e350d6d2e3ff9c14463a9.

chrismytton commented 7 years ago

And improved in https://github.com/everypolitician/compare_morph_to_wikidata/commit/e07ef205cd2fd6af9cb75664ba6524f85e903ac9 😄