search

everypolitician / everypolitician-docs

Source for EveryPolitician website's documentation pages
http://docs.everypolitician.org
1 stars 4 forks source link

add standard footer to all docs pages #21

Closed davewhiteland closed 8 years ago

davewhiteland commented 8 years ago

resources copied across from everypolitician/viewer-sinatra#10691 closes #20

Put this live in synch with the viewer-sinatra changes going live, since this is the same footer on all the site's pages regardless of which subdomain they're coming from (docs. or none).

davewhiteland commented 8 years ago

@zarino sanity check on this please, but seems to be lovely just by more-or-less dropping SASS and resources in from everypolitician/viewer-sinatra#10691

I think the one-third column containing mysoc-footer__legal is staying unexpectedly thin when the page is narrow, but I'm happy to go live (with viewer-sinatra too) now and sort that out later if you give me a 👍

zarino commented 8 years ago

@davewhiteland – I'm happy with the width of footer__legal (we can always fix it later if it bothers anyone).

I've left a few comments on other bits though. Primarily: you were @import-ing the footer styles twice, resulting in twice as much compiled CSS as required. Removing the dark-theme class from the body and _site-footer.scss will remove the need for duplication. And while you're there, I'd move all the variables into _variables.scss, as explained in the other comment.

davewhiteland commented 8 years ago

@zarino ooh good stuff, thanks

zarino commented 8 years ago

👍 Much better! Thanks!