everypolitician / everypolitician-popolo

Ruby gem for interacting with EveryPolitician data for a legislature
MIT License
7 stars 4 forks source link

Add Membership subclasses for LegislativeMembership and ComitteeMembership #105

Open struan opened 8 years ago

struan commented 8 years ago

Problem

We want to add methods that only makes sense for memberships of legislature (e.g legislature) but currently all memberships are the same class.

Proposed Solution

Add a LegislatureMembership subclass to Membership.

Acceptance Criteria

The JSON.memberships returns legislature membership objects, not Memberships

Not Required

Prerequisites

We need to agree on a way to return subclasses from a collection which is work happening as part or #67.

Related Issues

struan commented 8 years ago

Also, need to determine how to distinguish between the types of membership.