Closed tmtmtmtm closed 6 years ago
Attempting to update to rubocop 0.53 gives lots of new errors:
Offenses: everypolitician-popolo.gemspec:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. everypolitician-popolo.gemspec:2:12: C: Style/ExpandPathArguments: Use expand_path('lib', __dir__) instead of expand_path('../lib', __FILE__). lib = File.expand_path('../lib', __FILE__) ^^^^^^^^^^^ Gemfile:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. source 'https://rubygems.org' ^ Rakefile:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'bundler/gem_tasks' ^ bin/console:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. #!/usr/bin/env ruby ^ lib/everypolitician/popolo/area.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/collection.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/election.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/entity.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/event.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/legislative_period.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/membership.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/organization.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/person.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/post.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo/version.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. module Everypolitician ^ lib/everypolitician/popolo.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'json' ^ test/everypolitician/popolo/area_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/collection_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/event_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/json_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/membership_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/membership_test.rb:13:5: C: Naming/MemoizedInstanceVariableName: Memoized variable @mems does not match method name memberships. Use @memberships instead. @mems ||= Everypolitician::Popolo.read(fixture).memberships ^^^^^ test/everypolitician/popolo/organization_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/person_behaviour.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/person_behaviour.rb:9:5: C: Naming/MemoizedInstanceVariableName: Memoized variable @ppl does not match method name people. Use @people instead. @ppl ||= Everypolitician::Popolo.read(estonia_fixture).persons ^^^^ test/everypolitician/popolo/person_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo/person_test.rb:21:5: C: Naming/MemoizedInstanceVariableName: Memoized variable @ppl does not match method name people. Use @people instead. @ppl ||= Everypolitician::Popolo.read(estonia_fixture).persons ^^^^ test/everypolitician/popolo/person_test.rb:25:5: C: Naming/MemoizedInstanceVariableName: Memoized variable @pakistan_ppl does not match method name pakistan_people. Use @pakistan_people instead. @pakistan_ppl ||= Everypolitician::Popolo.read(pakistan_fixture).persons ^^^^^^^^^^^^^ test/everypolitician/popolo/person_test.rb:29:5: C: Naming/MemoizedInstanceVariableName: Memoized variable @burundi_ppl does not match method name burundi_people. Use @burundi_people instead. @burundi_ppl ||= Everypolitician::Popolo.read(burundi_fixture).persons ^^^^^^^^^^^^ test/everypolitician/popolo/person_test.rb:33:5: C: Naming/MemoizedInstanceVariableName: Memoized variable @zimbabwe_ppl does not match method name zimbabwe_people. Use @zimbabwe_people instead. @zimbabwe_ppl ||= Everypolitician::Popolo.read(zimbabwe_fixture).persons ^^^^^^^^^^^^^ test/everypolitician/popolo/post_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/everypolitician/popolo_test.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. require 'test_helper' ^ test/test_helper.rb:1:1: C: Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) ^ test/test_helper.rb:1:25: C: Style/ExpandPathArguments: Use expand_path('../lib', __dir__) instead of expand_path('../../lib', __FILE__). $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) ^^^^^^^^^^^
In theory we could add some of these to our TODO list, but ideally we'd fix them all.
We can update to 0.53 cleanly
Problem
Attempting to update to rubocop 0.53 gives lots of new errors:
Proposed Solution
In theory we could add some of these to our TODO list, but ideally we'd fix them all.
Acceptance Criteria
We can update to 0.53 cleanly