search

everypolitician / everypolitician-popolo

Ruby gem for interacting with EveryPolitician data for a legislature
MIT License
7 stars 4 forks source link

Create EntityWithDynamicMethods class #88

Closed ondenman closed 8 years ago

ondenman commented 8 years ago

As a step towards implementing real methods in Entity subclasses, we are moving dynamic method generation over to the EntityWithDynamicMethods Entity subclass. Dynamic method generation is removed from Entity.

All Entity subclasses now inherit from this as a stopgap -- classes will revert back to inheriting from Entity once they implement their own real methods. When all these subclasses use real methods, EntityWithDynamicMethods can be removed.

References: https://github.com/everypolitician/everypolitician-popolo/issues/54

tmtmtmtm commented 8 years ago

@struan / @ondenman I'm assuming this one can also now be closed?

ondenman commented 8 years ago

Closed in favour of: #99