search

everypolitician / everypolitician-ruby

Ruby gem for easy access to EveryPolitician data
http://everypolitician.org/
MIT License
14 stars 5 forks source link

Fix tests in legislature_test.rb #76

Closed henare closed 6 years ago

henare commented 6 years ago

This fixes #75. As per @tmtmtmtm's suspicions, the problem was indeed the around block - the test block wasn't being called so the body of the test never executed.

This pull request also (that naughty word!) includes a fix to one of the tests that were failing and tidies up the style. I think bundling this up into the one PR is justified because it's all for the ultimate goal of this PR, which is to get legislature_test.rb working. But I'd be happy to be called out as wrong :smile:

henare commented 6 years ago

Fixing the test that this reveals is broken is definitely OK in this context. It's not really an "also" in the sense that it could really be a separate change: it's more of an "and thus needed to".

Thanks @tmtmtmtm, that's helpful to me to clarify :star2: