Build data for the Senate as well as the House of Commons

everypolitician / proto-commons-canada

ALPHA repository for Democratic Commons data on Canada - don't rely on this structure or format

0 stars 1 forks source link

Build data for the Senate as well as the House of Commons #2

Closed mhl closed 6 years ago

mhl commented 6 years ago

Previously the build.rb script only built data for the House of Commons, and output the JSON to standard output. This pull request:

adds a file with Wikidata item IDs relevant to each legislature to build
changes the build script iterate over those legislatures and output to the right directory under legislative
adds data for the Senate

mhl commented 6 years ago

@tmtmtmtm Thanks for those suggestions. I've changed this so that either a term ID or a date range is required, and it's using Pathname for file / filename operations (much nicer!)

I feel like my use of keyword argument splatting isn't so clear as various other alternatives would be, but I think I've been prodding at this quite long enough now...