Open chrismytton opened 7 years ago
Some nice initial wins from extracting the output cleaning into a separate class in https://github.com/everypolitician/rebuilder/pull/64.
Next up I think is #43 https://github.com/everypolitician/rebuilder/issues/45, which has been started over in #63.
Problem
Currently the
RebuilderJob#perform
method is a big procedural mess. Making changes to the method isn't too difficult, but adding tests for those changes is near impossible.Proposed solution
Split this method up into discrete classes that are each well tested. We probably need at least the following concepts modelled as :
bundle install
and running the ep-datarake
tasks and capturing the output. See https://github.com/everypolitician/rebuilder/issues/45 and https://github.com/everypolitician/rebuilder/issues/52.