search

everypolitician / scraped_page_archive

Create an archive of HTML pages scraped by a Ruby scraper
MIT License
1 stars 0 forks source link

Extract git operations into a separate storage class #42

Closed chrismytton closed 8 years ago

chrismytton commented 8 years ago

This introduces a new GitStorage class which is an extraction of the git parts of the ScrapedPageArchive class. This should make it easier to test the git parts of this gem in isolation. It also means there is looser coupling between ScrapedPageArchive and git.

This change was spurred on by https://github.com/everypolitician/scraped_page_archive/pull/40#discussion_r80220902.

chrismytton commented 8 years ago

@tmtmtmtm 👀

chrismytton commented 8 years ago

@tmtmtmtm Feedback addressed. I think there's still some more that could be done to encapsulate the storage class, but this seems like a good starting point that we can build on in future PRs.

So I think this is ready for another :eyes:

chrismytton commented 8 years ago

Oops, I've broken the tests, fixing…