everypolitician / scraped_page_archive

Create an archive of HTML pages scraped by a Ruby scraper
MIT License
1 stars 0 forks source link

improve error message when git repo is missing #45

Closed davewhiteland closed 8 years ago

davewhiteland commented 8 years ago

Maybe

_"Could not determine git repo for 'scraped_pagearchive' in which to save scraped pages"

is better than

_"Could not determine git repo for 'scraped_pagearchive' to use"

because "to use" might imply the git repo specified in the Gemfile (which is this one, i.e., https://github.com/everypolitician/scraped_page_archive).

This issue based on real-world misunderstanding of the ambiguity of "git repo for". :-)

Error message at: https://github.com/everypolitician/scraped_page_archive/blob/2183c25c2694c91ba48d9630b09f73a0801434c9/lib/scraped_page_archive.rb#L29