search

everypolitician / scraped_page_archive

Create an archive of HTML pages scraped by a Ruby scraper
MIT License
1 stars 0 forks source link

Improve the error message when the repo url is wrong #46

Closed octopusinvitro closed 8 years ago

octopusinvitro commented 8 years ago

When there is a problem in a morph scraper that is using the archiver, and the problem is either the morph environment variable has the wrong name or the url is wrong, the gem will print an error message that may be considered not very helpful.

This PR takes @davewhiteland 's suggestion in #45 to make it clearer.

Closes #45

davewhiteland commented 8 years ago

Weee! So I did un-approve my own approval! I can be done (just by submitting a review that does request changes).

Right, I think this is a better error message:

The 'scraped_page_archive' gem wants to store the scraped pages in a git repo, but
it cannot determine which git repo it should use.  See 
https://github.com/everypolitician/scraped_page_archive#usage for details of how
to specify the repo.
octopusinvitro commented 8 years ago

@davewhiteland feedback addressed :+1:

octopusinvitro commented 8 years ago

@chrismytton Feedback addressed