everypolitician / scraper_test

Data-driven scraper tests for Scraped
0 stars 0 forks source link

Extract setup methods from install_tasks #17

Closed ondenman closed 7 years ago

ondenman commented 7 years ago

This PR is in preparation of https://github.com/everypolitician/scraper_test/pull/16

install_tasks has grown quite long. #16 will add further lines of code to the method but doing so will cause it to fail rubocop's line count check.

This PR extracts the Results class which takes a yaml test file and returns the actual and expected data.

ondenman commented 7 years ago

I'm not sure if it's necessary but I've created a branch with a more suitable name and have opened a new PR. https://github.com/everypolitician/scraper_test/pull/18