everypolitician / scraper_test

Data-driven scraper tests for Scraped
0 stars 0 forks source link

VCR should be turned off after running #2

Open chrismytton opened 7 years ago

chrismytton commented 7 years ago

Problem

I get the following error when I have a :rubocop rake task after the scraper_test :test task:

be rake                                                 0
Running RuboCop...

================================================================================
An HTTP request has been made that VCR does not know how to handle:
  GET https://raw.githubusercontent.com/everypolitician/everypolitician-data/master/.rubocop_base.yml

[snip]

Proposed solution

Switch off VCR after running.

chrismytton commented 7 years ago

Hmm, seems like that pull request didn't actually fix this problem. 😞

chrismytton commented 7 years ago

There's some experimental code in https://github.com/everypolitician/scraper_test/commit/9df102d2a48b5067ced44b441c8ee166c0db7200 which I think does what we need, but I need to test a bit more and turn into a proper PR.